(MODULES-2706) types and providers #130
Conversation
There was a problem hiding this comment.
Looks like this file needs to switch to 2-space indentation
lucywyman
changed the title
There was a problem hiding this comment.
Integers from puppet versions older than 4.0.0 can't actually pass integers; they only pass strings. Maybe check that strings work? (iirc anyway)
|
Looks like travis ci failure is unrelated to the changes in this pr. Maybe it's transient? |
spec/unit/type/filesystem_spec.rb
Outdated
|
https://travis-ci.org/puppetlabs/puppetlabs-lvm/jobs/90990611 These failures are expected, as we haven't addressed the '7+ doesn't fail' bug yet, and we (or Travis) is using a puppet version less than 4.0, so 7 instead of '7' should fail. Should I fix the '7+' bug here, or make a new issue and merge that first? |
|
Yeah, the 7+ bug is something you found by making the tests better, so if you want to fix the validation in the type (it needs a |
There was a problem hiding this comment.
Just need to put {}'s around all of the hashes passed to new to make ruby 1.8 pass
|
It's passing! It's passing! |
|
|
|
\o/ I think @hunner had a couple other suggestions.. and then a squash. Almost there! |
…al_volume Test that the name parameter of the filesystem type must be a fully qualified path. (MODULES-2706) Tests for physical_volume type Test :name and :unless_vg parameters are well formed. (MODULES-2706) Tests for Logical Volume Type name
(MODULES-2706) types and providers
6 participants
Is there anything else we need to add tests for, for types and providers?
I also wasn't sure whether to squash the commits or not -- let me know if I should!